Skip to content

fix(module:qrcode): remove event listeners once settled#8861

Merged
arturovt merged 1 commit intoNG-ZORRO:masterfrom
arturovt:fix/qr-cleanup
Nov 12, 2024
Merged

fix(module:qrcode): remove event listeners once settled#8861
arturovt merged 1 commit intoNG-ZORRO:masterfrom
arturovt:fix/qr-cleanup

Conversation

@arturovt
Copy link
Member

@arturovt arturovt commented Nov 7, 2024

No description provided.

@arturovt arturovt requested a review from OriginRing as a code owner November 7, 2024 23:35
@zorro-bot
Copy link

zorro-bot bot commented Nov 7, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.91%. Comparing base (d28876c) to head (4d63a0b).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
components/qr-code/qrcode.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8861      +/-   ##
==========================================
- Coverage   91.95%   91.91%   -0.04%     
==========================================
  Files         537      537              
  Lines       18452    18460       +8     
  Branches     2814     2814              
==========================================
  Hits        16967    16967              
- Misses       1183     1191       +8     
  Partials      302      302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, WDYT? @OriginRing

@Laffery Laffery changed the title fix(module:qr-code): remove event listeners once settled fix(module:qrcode): remove event listeners once settled Nov 12, 2024
@OriginRing
Copy link
Collaborator

LGTM

@arturovt arturovt merged commit 40d466d into NG-ZORRO:master Nov 12, 2024
@arturovt arturovt deleted the fix/qr-cleanup branch November 12, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants