fix(module:watermark): cleanup event listeners once settled#8862
Merged
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8862 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 537 537
Lines 18453 18460 +7
Branches 2814 2814
==========================================
+ Hits 16955 16961 +6
- Misses 1196 1197 +1
Partials 302 302 ☔ View full report in Codecov by Sentry. |
Laffery
approved these changes
Nov 9, 2024
Collaborator
Laffery
left a comment
Laffery
left a comment
There was a problem hiding this comment.
LGTM. WDYT? @OriginRing
Laffery
changed the title
Collaborator
|
@arturovt Please fix the CI errors, which might be caused by a previous commit had been fixed, try to rebase |
OriginRing
approved these changes
Nov 12, 2024
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.