Skip to content

Conversation

@firefighter-19
Copy link
Contributor

… 'a' tag problem with 'null' or 'undefined' value if templateRef provided

https://stackblitz.com/edit/stackblitz-starters-1rvbyj?file=src%2Fmain.ts

Stackblitz example added.

@zorro-bot
Copy link

zorro-bot bot commented Nov 8, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (c5478f6) to head (883aef8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8864   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         537      537           
  Lines       18453    18453           
  Branches     2814     2814           
=======================================
  Hits        16968    16968           
  Misses       1183     1183           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119
Copy link
Collaborator

Could you change the commit message to fix(module:anchor): ... ? :)

@firefighter-19
Copy link
Contributor Author

Could you change the commit message to fix(module:anchor): ... ? :)

fixed :)

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 changed the title fix (nz-anchor title-replace 'tittle' attribute to 'attr.title'): fix… fix(module:anchor): fix 'a' tag problem with 'null' or 'undefined' value if templateRef provided Nov 11, 2024
@Laffery Laffery merged commit 41f6609 into NG-ZORRO:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants