Skip to content

fix(module:autocomplete): remove inline style (CSP compliant)#8875

Merged
Laffery merged 2 commits intoNG-ZORRO:masterfrom
arturovt:fix/autocomplete-csp
Nov 18, 2024
Merged

fix(module:autocomplete): remove inline style (CSP compliant)#8875
Laffery merged 2 commits intoNG-ZORRO:masterfrom
arturovt:fix/autocomplete-csp

Conversation

@arturovt
Copy link
Copy Markdown
Member

No description provided.

@arturovt arturovt requested a review from hsuanxyz as a code owner November 12, 2024 16:22
@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Nov 12, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (40d466d) to head (b6582f3).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8875   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         537      537           
  Lines       18460    18469    +9     
  Branches     2814     2814           
=======================================
+ Hits        16954    16963    +9     
  Misses       1204     1204           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<div style="max-height: 256px; overflow-y: auto; overflow-anchor: none;">
<div style="display: flex; flex-direction: column;">
<div class="ant-select-dropdown-content-wrapper">
<div class="ant-select-dropdown-content-wrapper">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="ant-select-dropdown-content-wrapper">
<div class="ant-select-dropdown-content">

Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 30c25f0 into NG-ZORRO:master Nov 18, 2024
@arturovt arturovt deleted the fix/autocomplete-csp branch November 18, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants