feat(module:popover): add nzPopoverOverlayClickable to disable click on mask#8878
Merged
Merged
Conversation
|
This preview will be available after the AzureCI is passed. |
OriginRing
force-pushed
the
feat/cdkConnectedOverlay
branch
from
d55ccf5 to
372756c
Compare
OriginRing
force-pushed
the
feat/cdkConnectedOverlay
branch
from
372756c to
90214cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8878 +/- ##
=======================================
Coverage 91.90% 91.91%
=======================================
Files 555 555
Lines 19711 19717 +6
Branches 2944 2946 +2
=======================================
+ Hits 18116 18122 +6
Misses 1268 1268
Partials 327 327 ☔ View full report in Codecov by Sentry. |
Laffery
requested changes
Nov 14, 2024
Collaborator
Laffery
left a comment
Laffery
left a comment
There was a problem hiding this comment.
1 comments, and please add unit tests
Laffery
added
PR: reviewed-changes-requested
PR: need-test
OriginRing
force-pushed
the
feat/cdkConnectedOverlay
branch
3 times, most recently
from
5774cbc to
21cd1c9
Compare
Laffery
reviewed
Nov 20, 2024
Laffery
reviewed
Nov 20, 2024
Laffery
reviewed
Nov 20, 2024
OriginRing
force-pushed
the
feat/cdkConnectedOverlay
branch
2 times, most recently
from
a1e5e21 to
0ca53d8
Compare
Laffery
reviewed
Nov 22, 2024
OriginRing
force-pushed
the
feat/cdkConnectedOverlay
branch
from
0ca53d8 to
c07252b
Compare
HyperLife1119
added
PR: need-rebase
and removed
PR: need-test
OriginRing
force-pushed
the
feat/cdkConnectedOverlay
branch
2 times, most recently
from
bfdd018 to
a1a6c2a
Compare
Laffery
requested changes
Jan 14, 2025
| @ViewChild('changePopover', { static: true, read: NzPopoverDirective }) | ||
| changePopoverNzPopoverDirective!: NzPopoverDirective; | ||
|
|
||
| @ViewChild('hideTemplate', { static: false }) hideTemplate!: ElementRef; |
OriginRing
force-pushed
the
feat/cdkConnectedOverlay
branch
from
a1a6c2a to
bf6f21c
Compare
Laffery
changed the title
Laffery
changed the title
nzPopoverOverlayClickable to disable click on mask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information