Skip to content

fix(module:drawer): should clear previously focused element#8893

Merged
Laffery merged 31 commits into
NG-ZORRO:masterfrom
ParsaArvanehPA:feature/drawer-not-setting-new-focus-element
Nov 25, 2024
Merged

fix(module:drawer): should clear previously focused element#8893
Laffery merged 31 commits into
NG-ZORRO:masterfrom
ParsaArvanehPA:feature/drawer-not-setting-new-focus-element

Conversation

@ParsaArvanehPA

@ParsaArvanehPA ParsaArvanehPA commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

When a drawer is opened, the previously focused element is saved. This allows the element to be refocused when the drawer is closed. If no element was previously focused, the new focused element is set upon opening the drawer. In this case, the previous focus value is cleared. So by clearing the value upon closing the drawer, the correct behavior is acheived.

Issue Number: #8839

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

ParsaArvanehPA and others added 30 commits February 1, 2024 22:52
@ParsaArvanehPA ParsaArvanehPA changed the title Feature/drawer not setting new focus element fix(module:drawer): should clear previously focused element Nov 23, 2024
@codecov

codecov Bot commented Nov 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (68f6324) to head (3dde607).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8893      +/-   ##
==========================================
- Coverage   91.94%   91.89%   -0.06%     
==========================================
  Files         537      546       +9     
  Lines       18455    19292     +837     
  Branches     2816     2850      +34     
==========================================
+ Hits        16969    17728     +759     
- Misses       1182     1252      +70     
- Partials      304      312       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants