feat: redesign the input-number#8901
Merged
Merged
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8901 +/- ##
==========================================
+ Coverage 91.84% 91.88% +0.04%
==========================================
Files 548 552 +4
Lines 19305 19491 +186
Branches 2862 2893 +31
==========================================
+ Hits 17730 17909 +179
- Misses 1260 1265 +5
- Partials 315 317 +2 ☔ View full report in Codecov by Sentry. |
Closed
6f344f5 to
fa226ea
Compare
925ec6f to
973edb0
Compare
349886a to
e632e8e
Compare
e632e8e to
93791a6
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
旧版组件的开发体验不佳,与 antd 标准实现差异大。
What is the new behavior?
ng-zorro-antd/input-number-legacy(样式文件除外)nz-input-number-legacyNzInputNumberComponent重命名为NzInputNumberLegacyComponentNzInputNumberModule重命名为NzInputNumberLegacyModuleNzInputNumberLegacyModule及其包含的所有组件与指令input模块新增如下指令:NzInputPrefixDirectiveNzInputSuffixDirectiveNzInputAddonBeforeDirectiveNzInputAddonAfterDirective由于未来
input模块也需要用到这些指令,并且input-number隶属于input,所以input-number也将从input模块中复用这些指令。<nz-input-number-group><ng-template>Does this PR introduce a breaking change?
Other information