Skip to content

chore: remove FADE_CLASS_NAME_MAP and IMAGE_PREVIEW_MASK_CLASS_NAME#8912

Merged
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
Laffery:chore/remove-deprecated-api-v19
Dec 5, 2024
Merged

chore: remove FADE_CLASS_NAME_MAP and IMAGE_PREVIEW_MASK_CLASS_NAME#8912
HyperLife1119 merged 1 commit intoNG-ZORRO:masterfrom
Laffery:chore/remove-deprecated-api-v19

Conversation

@Laffery
Copy link
Copy Markdown
Collaborator

@Laffery Laffery commented Dec 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

移除此前标记将在 v19 移除的 API

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Laffery Laffery added 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: unreviewed PR: target-major Component: Image labels Dec 5, 2024
@Laffery Laffery added this to the v19 milestone Dec 5, 2024
@zorro-bot zorro-bot bot requested a review from stygian-desolator December 5, 2024 09:16
@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Dec 5, 2024

This preview will be available after the AzureCI is passed.

@Laffery Laffery requested a review from HyperLife1119 December 5, 2024 09:16
Copy link
Copy Markdown
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (a65a32f) to head (58d821a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8912      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.02%     
==========================================
  Files         554      554              
  Lines       19684    19682       -2     
  Branches     2936     2936              
==========================================
- Hits        18095    18091       -4     
- Misses       1264     1265       +1     
- Partials      325      326       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 merged commit 65223d9 into NG-ZORRO:master Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💔 Breaking Change This PR or the solution to this issue would introduce breaking changes Component: Image PR: reviewed-approved PR: target-major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants