feat(module:checkbox): redesign the checkbox group component#8932
Merged
Laffery merged 1 commit intoNG-ZORRO:masterfrom Dec 15, 2024
Merged
feat(module:checkbox): redesign the checkbox group component#8932Laffery merged 1 commit intoNG-ZORRO:masterfrom
Laffery merged 1 commit intoNG-ZORRO:masterfrom
Conversation
f6a04fc to
2dcbdd4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8932 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 554 555 +1
Lines 19682 19697 +15
Branches 2936 2940 +4
=======================================
+ Hits 18091 18105 +14
- Misses 1265 1267 +2
+ Partials 326 325 -1 ☔ View full report in Codecov by Sentry. |
e6e7a6d to
bff57eb
Compare
Laffery
requested changes
Dec 14, 2024
9b78ba2 to
e124bf8
Compare
e124bf8 to
a6c0a0c
Compare
HyperLife1119
commented
Dec 14, 2024
a6c0a0c to
8ada51c
Compare
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4883
<nz-checkbox-group>的ngModel的类型为NzCheckBoxOptionInterface[],与 antd 不一致<nz-checkbox-group>无法像 antd 那样自定义布局,需要借助<nz-checkbox-wrapper>组件实现自定义布局,但<nz-checkbox-wrapper>又不是一个控件组件,用途不大。实际上<nz-checkbox-wrapper>应该被实现为<nz-checkbox-group>。What is the new behavior?
<nz-checkbox-group>的ngModel的类型修正为NzCheckBoxOptionInterface['value'][]<nz-checkbox-group>支持自定义布局<nz-checkbox-group>新增[nzOptions]<nz-checkbox-group>新增[nzName][nz-checkbox]新增[nzName]<nz-checkbox-wrapper>NzCheckBoxOptionInterface,使用NzCheckBoxOption替代Does this PR introduce a breaking change?
<nz-checkbox-group>的ngModel的类型修改为NzCheckBoxOptionInterface['value'][]NzCheckBoxOptionInterface['checked']Other information