Skip to content

feat(module:cascader): support nzPlacement#8935

Merged
HyperLife1119 merged 2 commits intoNG-ZORRO:masterfrom
Laffery:feat/cascader-placement
Dec 15, 2024
Merged

feat(module:cascader): support nzPlacement#8935
HyperLife1119 merged 2 commits intoNG-ZORRO:masterfrom
Laffery:feat/cascader-placement

Conversation

@Laffery
Copy link
Copy Markdown
Collaborator

@Laffery Laffery commented Dec 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Dec 15, 2024

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (489e0de) to head (3d72570).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
components/cascader/cascader.component.ts 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8935      +/-   ##
==========================================
+ Coverage   91.86%   91.90%   +0.04%     
==========================================
  Files         555      555              
  Lines       19697    19709      +12     
  Branches     2940     2942       +2     
==========================================
+ Hits        18095    18114      +19     
+ Misses       1276     1268       -8     
- Partials      326      327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants