Skip to content

fix(module:input-number): fix NG0600 error#8955

Merged
Laffery merged 1 commit intoNG-ZORRO:masterfrom
HyperLife1119:fix/number-NG0600
Jan 3, 2025
Merged

fix(module:input-number): fix NG0600 error#8955
Laffery merged 1 commit intoNG-ZORRO:masterfrom
HyperLife1119:fix/number-NG0600

Conversation

@HyperLife1119
Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #8953

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Jan 2, 2025

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (5ffa099) to head (73ad55a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8955      +/-   ##
==========================================
- Coverage   91.91%   91.90%   -0.02%     
==========================================
  Files         555      555              
  Lines       19708    19708              
  Branches     2942     2943       +1     
==========================================
- Hits        18115    18112       -3     
- Misses       1267     1269       +2     
- Partials      326      327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 8d6135e into NG-ZORRO:master Jan 3, 2025
@VitaliiLitkevich
Copy link
Copy Markdown

Hi! I have the same problem when i try to disable form control
https://stackblitz.com/edit/nhsamgsd?file=src%2Fapp%2Fapp.component.ts

@HyperLife1119
Copy link
Copy Markdown
Collaborator Author

Thanks for your report, this will be fixed in the next patch release :) @VitaliiLitkevich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New input-number signal error

3 participants