Skip to content

Conversation

@HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Jan 9, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

NG0956: The configured tracking expression (track by identity) caused re-creation of the entire collection of size 1. This is an expensive operation requiring destruction and subsequent creation of DOM nodes, directives, components etc. Please review the "track expression" and make sure that it uniquely identifies items in a collection. Find more at https://angular.dev/errors/NG0956

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 9, 2025

This preview will be available after the AzureCI is passed.

@HyperLife1119 HyperLife1119 changed the title Fix/progress-ng0956 fix(module:progress): fix NG0956 error Jan 9, 2025
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (79cc2f8) to head (599bc58).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8962      +/-   ##
==========================================
+ Coverage   91.90%   91.91%   +0.01%     
==========================================
  Files         555      555              
  Lines       19711    19711              
  Branches     2944     2944              
==========================================
+ Hits        18115    18117       +2     
+ Misses       1269     1268       -1     
+ Partials      327      326       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit c4d2f81 into NG-ZORRO:master Jan 9, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants