Skip to content

fix(module:nz-tree-select): fix error when judging multiple instance condition#9008

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
EnochGao:fix-#8983
Feb 19, 2025
Merged

fix(module:nz-tree-select): fix error when judging multiple instance condition#9008
Laffery merged 1 commit into
NG-ZORRO:masterfrom
EnochGao:fix-#8983

Conversation

@EnochGao
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

An error is reported when judging multiple instance conditions
https://stackblitz.com/edit/kzn1gfa7-2qtub7c7?file=src%2Fapp%2Fapp.component.ts

Issue Number: #8983

What is the new behavior?

Multiinstance normal

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

@EnochGao EnochGao requested a review from hsuanxyz as a code owner February 14, 2025 09:17
@zorro-bot
Copy link
Copy Markdown

zorro-bot Bot commented Feb 14, 2025

This preview will be available after the AzureCI is passed.

@EnochGao EnochGao changed the title fix(module:nz-tree-select): fix the #8983 fix(module:nz-tree-select): fix the #8983, an error is reported when judging multiple instance conditions Feb 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (1f8f4da) to head (40866bb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9008   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files         555      555           
  Lines       19708    19708           
  Branches     2946     2945    -1     
=======================================
  Hits        18121    18121           
  Misses       1261     1261           
  Partials      326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery Laffery changed the title fix(module:nz-tree-select): fix the #8983, an error is reported when judging multiple instance conditions fix(module:nz-tree-select): fix error when judging multiple instance condition Feb 19, 2025
@Laffery Laffery merged commit 5006ea6 into NG-ZORRO:master Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants