Skip to content

fix(module:segmented): fix error with the FormControl first change#9039

Merged
HyperLife1119 merged 1 commit into
NG-ZORRO:masterfrom
xiayu1996:fix/9031
Mar 10, 2025
Merged

fix(module:segmented): fix error with the FormControl first change#9039
HyperLife1119 merged 1 commit into
NG-ZORRO:masterfrom
xiayu1996:fix/9031

Conversation

@xiayu1996
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

NzSegmented with FormControl first change doesnt work
https://stackblitz.com/edit/duxusgu5?file=src%2Fapp%2Fapp.component.ts
Issue Number: #9031

What is the new behavior?

Segmented item is selected when the first change with FormControl

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@xiayu1996 xiayu1996 requested a review from simplejason as a code owner March 9, 2025 13:16
@zorro-bot
Copy link
Copy Markdown

zorro-bot Bot commented Mar 9, 2025

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (8a62816) to head (a345c63).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9039   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         559      559           
  Lines       19768    19770    +2     
  Branches     3050     3050           
=======================================
+ Hits        18177    18179    +2     
  Misses       1265     1265           
  Partials      326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit 33fe53d into NG-ZORRO:master Mar 10, 2025
@xiayu1996 xiayu1996 deleted the fix/9031 branch March 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NzSegmented with FormControl first change doesnt work

2 participants