Skip to content

feat(module:pageheader): disable back button if no history#9041

Merged
Laffery merged 2 commits into
NG-ZORRO:masterfrom
Nicoss54:feature/disable-back-button-no-history
Mar 14, 2025
Merged

feat(module:pageheader): disable back button if no history#9041
Laffery merged 2 commits into
NG-ZORRO:masterfrom
Nicoss54:feature/disable-back-button-no-history

Conversation

@Nicoss54

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently back button in Page Header component is never disabled even if there is no history entry

Issue Number: N/A

What is the new behavior?

Back button is disabled is there is no entry in the history navigation

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Nicoss54 Nicoss54 requested a review from CK110 as a code owner March 10, 2025 17:57
@Nicoss54 Nicoss54 requested a review from HyperLife1119 March 10, 2025 17:57
@Nicoss54 Nicoss54 self-assigned this Mar 10, 2025
@zorro-bot

zorro-bot Bot commented Mar 10, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Mar 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.95%. Comparing base (2d9ff5f) to head (c7ca89b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
components/page-header/page-header.component.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9041      +/-   ##
==========================================
+ Coverage   91.94%   91.95%   +0.01%     
==========================================
  Files         559      559              
  Lines       19769    19773       +4     
  Branches     3050     3050              
==========================================
+ Hits        18176    18182       +6     
+ Misses       1266     1265       -1     
+ Partials      327      326       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread components/page-header/page-header.component.ts Outdated
@Nicoss54 Nicoss54 force-pushed the feature/disable-back-button-no-history branch 2 times, most recently from 02f6078 to 600e47c Compare March 12, 2025 09:31
@HyperLife1119 HyperLife1119 requested a review from Laffery March 13, 2025 01:41
Comment thread components/page-header/page-header.component.ts Outdated
Comment thread components/page-header/page-header.component.ts Outdated
Comment thread components/page-header/page-header.component.ts Outdated
Comment thread components/page-header/page-header.component.ts Outdated
@Nicoss54 Nicoss54 force-pushed the feature/disable-back-button-no-history branch 3 times, most recently from 258775b to f8f9974 Compare March 13, 2025 13:30
@Nicoss54 Nicoss54 requested a review from HyperLife1119 March 13, 2025 13:35
@Nicoss54 Nicoss54 force-pushed the feature/disable-back-button-no-history branch 2 times, most recently from dc58734 to d8645ca Compare March 13, 2025 16:48
Comment thread package-lock.json
@Nicoss54 Nicoss54 force-pushed the feature/disable-back-button-no-history branch from d8645ca to 84a1cd4 Compare March 13, 2025 17:02
@Nicoss54

Nicoss54 commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator Author

@HyperLife1119 have an issue with build on the pipeline but i can't reproduce in local, could you help or have an idea ?

Nothing change between the two changes I made :/. Change between the two reviews have no impact on the error.

We have this error because the prerendering take two much time! Investigating angular repo Timeout occurs after 30s

Comment thread components/page-header/page-header.component.ts Outdated
@Nicoss54 Nicoss54 force-pushed the feature/disable-back-button-no-history branch from 84a1cd4 to 15e0aca Compare March 14, 2025 07:01
@Nicoss54 Nicoss54 force-pushed the feature/disable-back-button-no-history branch from 15e0aca to 52c741b Compare March 14, 2025 07:07
@Nicoss54 Nicoss54 requested a review from HyperLife1119 March 14, 2025 07:22

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants