feat(module:pageheader): disable back button if no history#9041
Merged
Laffery merged 2 commits intoMar 14, 2025
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9041 +/- ##
==========================================
+ Coverage 91.94% 91.95% +0.01%
==========================================
Files 559 559
Lines 19769 19773 +4
Branches 3050 3050
==========================================
+ Hits 18176 18182 +6
+ Misses 1266 1265 -1
+ Partials 327 326 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
02f6078 to
600e47c
Compare
258775b to
f8f9974
Compare
dc58734 to
d8645ca
Compare
d8645ca to
84a1cd4
Compare
Collaborator
Author
|
@HyperLife1119 have an issue with build on the pipeline but i can't reproduce in local, could you help or have an idea ? Nothing change between the two changes I made :/. Change between the two reviews have no impact on the error. We have this error because the prerendering take two much time! Investigating angular repo Timeout occurs after 30s |
84a1cd4 to
15e0aca
Compare
15e0aca to
52c741b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently back button in Page Header component is never disabled even if there is no history entry
Issue Number: N/A
What is the new behavior?
Back button is disabled is there is no entry in the history navigation
Does this PR introduce a breaking change?
Other information