Skip to content

fix(module:select): bugfix for changing ngModel value of mutilple select with nzMaxMultipleCount - #9056

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
WwwHhhYran:fix/ngModel_for_mutilple_select
Mar 27, 2025
Merged

Laffery merged 1 commit into
NG-ZORRO:masterfrom
WwwHhhYran:fix/ngModel_for_mutilple_select

Conversation

@WwwHhhYran

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #9055

What is the new behavior?

when change ngModel value of the select component, the disabled status of options will match expectation

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@WwwHhhYran
WwwHhhYran requested a review from vthinkxie as a code owner March 20, 2025 03:50
@zorro-bot

zorro-bot Bot commented Mar 20, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Mar 20, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (815fcfd) to head (543a4be).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9056   +/-   ##
=======================================
  Coverage   91.93%   91.94%           
=======================================
  Files         559      559           
  Lines       19773    19772    -1     
  Branches     3050     3050           
=======================================
+ Hits        18179    18180    +1     
+ Misses       1268     1267    -1     
+ Partials      326      325    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit d7031da into NG-ZORRO:master Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nz-select nzMaxMultipleCount bug: All options are disabled when the select field has reached its limit and then the value is cleared

2 participants