Skip to content

fix(module:select): disable nzMaxMultipleCount in default mode#9068

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Laffery:fix/select-maxCount-safeguard
Mar 27, 2025
Merged

fix(module:select): disable nzMaxMultipleCount in default mode#9068
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Laffery:fix/select-maxCount-safeguard

Conversation

@Laffery

@Laffery Laffery commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: fix #9057

What is the new behavior?

default 模式下(非多选模式下),设置 nzMaxMultipleCount 将不生效

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Laffery
Laffery requested a review from vthinkxie as a code owner March 27, 2025 07:35
@zorro-bot

zorro-bot Bot commented Mar 27, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Mar 27, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (d7031da) to head (7920be4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9068   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         564      564           
  Lines       20021    20025    +4     
  Branches     3104     3106    +2     
=======================================
+ Hits        18420    18425    +5     
+ Misses       1262     1261    -1     
  Partials      339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WwwHhhYran WwwHhhYran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit dcf8a5d into NG-ZORRO:master Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nz-select feature request - Disable the nzMaxMultipleCount Feature in Default Mode

2 participants