Skip to content

fix(module:select): remove internal comment from select-arrow - #9074

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Laffery:hotfix/select-arrow
Mar 29, 2025
Merged

Laffery merged 1 commit into
NG-ZORRO:masterfrom
Laffery:hotfix/select-arrow

Conversation

@Laffery

@Laffery Laffery commented Mar 29, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: fix #9071

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Laffery
Laffery requested a review from vthinkxie as a code owner March 29, 2025 01:22
@zorro-bot

zorro-bot Bot commented Mar 29, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@Laffery Laffery changed the title refactor(module:select): remove internal comment from select-arrow fix(module:select): remove internal comment from select-arrow Mar 29, 2025
@codecov

codecov Bot commented Mar 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (937028f) to head (e1ca213).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9074   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         564      564           
  Lines       20025    20025           
  Branches     3106     3106           
=======================================
+ Hits        18424    18425    +1     
+ Misses       1262     1261    -1     
  Partials      339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery
Laffery merged commit c9b2dd9 into NG-ZORRO:master Mar 29, 2025
@Laffery
Laffery deleted the hotfix/select-arrow branch June 27, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NzSelectModule Can't imports / exports

1 participant