fix(module:tabs): nzLinkRouter not work for the first time#9118
Merged
HyperLife1119 merged 1 commit intoMay 1, 2025
Merged
Conversation
|
This preview will be available after the AzureCI is passed. |
Laffery
commented
May 1, 2025
| ) | ||
| .pipe(takeUntil(this.destroy$), startWith(true)) | ||
| merge(this.router.events.pipe(filter(e => e instanceof NavigationEnd)), this.tabLinks.changes) | ||
| .pipe(delay(0), takeUntil(this.destroy$)) |
Collaborator
Author
There was a problem hiding this comment.
delay(0) is necessary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9118 +/- ##
==========================================
- Coverage 92.01% 92.01% -0.01%
==========================================
Files 565 565
Lines 20041 20040 -1
Branches 3006 3006
==========================================
- Hits 18441 18440 -1
Misses 1261 1261
Partials 339 339 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Laffery
commented
May 1, 2025
| ), | ||
| this.tabLinks.changes | ||
| ) | ||
| .pipe(takeUntil(this.destroy$), startWith(true)) |
Collaborator
Author
There was a problem hiding this comment.
startWith(true) can be removed due to this.tabLinks.changes will emit an event anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: close #9083
What is the new behavior?
Does this PR introduce a breaking change?
Other information