Skip to content

feat(module:popover): add nzPopoverTitleContext and nzPopoverContentContext#9126

Merged
Laffery merged 8 commits into
NG-ZORRO:masterfrom
tossp:ts-popover
Jun 6, 2025
Merged

feat(module:popover): add nzPopoverTitleContext and nzPopoverContentContext#9126
Laffery merged 8 commits into
NG-ZORRO:masterfrom
tossp:ts-popover

Conversation

@tossp
Copy link
Copy Markdown
Contributor

@tossp tossp commented May 20, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number:
fix #8883

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@tossp tossp requested a review from simplejason as a code owner May 20, 2025 13:34
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (89d0767) to head (dcb12be).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9126      +/-   ##
==========================================
+ Coverage   92.00%   92.10%   +0.09%     
==========================================
  Files         565      560       -5     
  Lines       20063    20005      -58     
  Branches     3012     3007       -5     
==========================================
- Hits        18459    18425      -34     
+ Misses       1264     1241      -23     
+ Partials      340      339       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please and unit tests for the new props

Comment thread components/popover/popover.ts Outdated
Comment thread components/popover/popover.ts Outdated
Comment thread components/popover/popover.ts Outdated
tossp and others added 6 commits May 24, 2025 06:25
Co-authored-by: Laffery <49607541+Laffery@users.noreply.github.com>
Co-authored-by: Laffery <49607541+Laffery@users.noreply.github.com>
Co-authored-by: Laffery <49607541+Laffery@users.noreply.github.com>
@tossp tossp requested a review from Laffery May 24, 2025 09:29
Copy link
Copy Markdown
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread components/popover/doc/index.en-US.md Outdated
Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery changed the title feat(module:popover): support popover template context feat(module:popover): add nzPopoverTitleContext and nzPopoverContentContext Jun 6, 2025
@Laffery Laffery merged commit df3ead9 into NG-ZORRO:master Jun 6, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng-popover组件期望可以接收上下文

3 participants