Skip to content

fix(module:tabs): nzLinkRouter not work for the first time load#9130

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Laffery:fix/tab-with-router
May 24, 2025
Merged

fix(module:tabs): nzLinkRouter not work for the first time load#9130
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Laffery:fix/tab-with-router

Conversation

@Laffery

@Laffery Laffery commented May 23, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: fix #9083

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Laffery
Laffery requested a review from hsuanxyz as a code owner May 23, 2025 23:21
@zorro-bot

zorro-bot Bot commented May 23, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented May 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (0aadfdf) to head (90cb9a9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9130   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files         565      565           
  Lines       20063    20064    +1     
  Branches     3012     3012           
=======================================
+ Hits        18461    18462    +1     
- Misses       1263     1264    +1     
+ Partials      339      338    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nz-tabset's nzLinkRouter not working properly when the app is built for production and it uses lazy-loaded routing modules

2 participants