Skip to content

fix(schematics): ng add failed when call twice - #9171

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Nicoss54:fix/ng-add-twice
Jun 16, 2025
Merged

fix(schematics): ng add failed when call twice#9171
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Nicoss54:fix/ng-add-twice

Conversation

@Nicoss54

@Nicoss54 Nicoss54 commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

If you run the schematics twice, one time after another one the second time the schematics fails with getText of undefined.

Issue Number: N/A

What is the new behavior?

It not failed anymore

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zorro-bot

zorro-bot Bot commented Jun 8, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jun 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (f4b9ba8) to head (2121f32).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9171      +/-   ##
==========================================
- Coverage   92.10%   92.06%   -0.04%     
==========================================
  Files         561      561              
  Lines       20009    20009              
  Branches     3009     3009              
==========================================
- Hits        18430    18422       -8     
- Misses       1239     1247       +8     
  Partials      340      340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery

Laffery commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

I find an issue #8967 which might be related, I will take a review later

@Nicoss54

Nicoss54 commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator Author

@Laffery oh yes, I saw this issue et that why I made this fix. Apologies for forgotten to link the issue :/

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit d0a9748 into NG-ZORRO:master Jun 16, 2025
@Nicoss54
Nicoss54 deleted the fix/ng-add-twice branch June 24, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants