Skip to content

fix(module:tabs): prevent incorrect scroll offset on tab focus - #9186

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
xiayu1996:master
Jun 11, 2025
Merged

fix(module:tabs): prevent incorrect scroll offset on tab focus#9186
Laffery merged 1 commit into
NG-ZORRO:masterfrom
xiayu1996:master

Conversation

@xiayu1996

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #9054

What is the new behavior?

Modify NzTabNavItemDirective's focus function to prevent the auto-scroll that makes the incorrect offset of NzTabNavBarComponent

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@xiayu1996
xiayu1996 requested a review from hsuanxyz as a code owner June 11, 2025 04:18
@zorro-bot

zorro-bot Bot commented Jun 11, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jun 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.11%. Comparing base (9198941) to head (1ec8d92).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9186   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         561      561           
  Lines       19989    19989           
  Branches     3009     3009           
=======================================
  Hits        18413    18413           
  Misses       1236     1236           
  Partials      340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants