Skip to content

feat(module:select): add nzOnClear callback - #9188

Merged
Laffery merged 2 commits into
masterfrom
feature/nz-on-clear-emitter
Jun 13, 2025
Merged

feat(module:select): add nzOnClear callback#9188
Laffery merged 2 commits into
masterfrom
feature/nz-on-clear-emitter

Conversation

@Nicoss54

@Nicoss54 Nicoss54 commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Nicoss54
Nicoss54 requested a review from vthinkxie as a code owner June 11, 2025 14:01
@zorro-bot

zorro-bot Bot commented Jun 11, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jun 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.70%. Comparing base (e48d672) to head (4a1ffa1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9188       +/-   ##
===========================================
- Coverage   92.08%   23.70%   -68.39%     
===========================================
  Files         561      561               
  Lines       19883    19885        +2     
  Branches     3005     3005               
===========================================
- Hits        18309     4713    -13596     
- Misses       1234    15135    +13901     
+ Partials      340       37      -303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HyperLife1119 HyperLife1119 changed the title feat(module:select): add nzOnCleat callback feat(module:select): add nzOnClear callback Jun 11, 2025

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54 Nicoss54 linked an issue Jun 12, 2025 that may be closed by this pull request

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description of nzOnClear should be changed :)

Comment thread components/select/doc/index.en-US.md Outdated
Comment thread components/select/doc/index.zh-CN.md Outdated
@Nicoss54
Nicoss54 force-pushed the feature/nz-on-clear-emitter branch from 71699ca to 4a1ffa1 Compare June 13, 2025 07:00
@Nicoss54

Copy link
Copy Markdown
Collaborator Author

@Laffery documentation is changed

@Nicoss54
Nicoss54 requested a review from Laffery June 13, 2025 07:00

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit e047ac2 into master Jun 13, 2025
@Nicoss54
Nicoss54 deleted the feature/nz-on-clear-emitter branch June 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add nzOnClear callback to nz-select

3 participants