Skip to content

refactor(module:core): cleanup animation frame polyfill - #9243

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
arturovt:refactor/cleanup-frame
Jun 24, 2025
Merged

refactor(module:core): cleanup animation frame polyfill#9243
Laffery merged 1 commit into
NG-ZORRO:masterfrom
arturovt:refactor/cleanup-frame

Conversation

@arturovt

@arturovt arturovt commented Jun 23, 2025

Copy link
Copy Markdown
Member

The reqAnimFrame polyfill was originally designed for legacy browser support, but it is now unnecessary, particularly in Angular, which targets only evergreen browsers.

BREAKING CHANGE:
refactoring in ng-zorro-antd/core/polyfill:

  • rename cancelRequestAnimationFrame to cancelAnimationFrame
  • rename reqAnimFrame to requestAnimationFrame

The `reqAnimFrame` polyfill was originally designed for legacy browser support, but it is now unnecessary, particularly in Angular, which targets only evergreen browsers.
@zorro-bot

zorro-bot Bot commented Jun 23, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jun 23, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.04%. Comparing base (42bbb0c) to head (d4e0a94).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
components/core/polyfill/request-animation.ts 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9243      +/-   ##
==========================================
+ Coverage   91.99%   92.04%   +0.05%     
==========================================
  Files         560      560              
  Lines       19617    19592      -25     
  Branches     3095     3089       -6     
==========================================
- Hits        18047    18034      -13     
+ Misses       1233     1219      -14     
- Partials      337      339       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery added 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: reviewed-approved and removed PR: partially-approved labels Jun 24, 2025

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit 272237a into NG-ZORRO:master Jun 24, 2025
@arturovt
arturovt deleted the refactor/cleanup-frame branch June 24, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: reviewed-approved PR: target-major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants