Skip to content

feat(module:float-button): support nzPlacement - #9267

Merged
Laffery merged 5 commits into
NG-ZORRO:masterfrom
WwwHhhYran:feat/support_nzPlacement_for_float_btn
Jul 17, 2025
Merged

feat(module:float-button): support nzPlacement#9267
Laffery merged 5 commits into
NG-ZORRO:masterfrom
WwwHhhYran:feat/support_nzPlacement_for_float_btn

Conversation

@WwwHhhYran

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the new behavior?

you can set nzPlacement for nz-float-button-group to customize the pop placement of its menu buttons
截屏2025-07-02 20 53 08

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@WwwHhhYran
WwwHhhYran requested a review from OriginRing as a code owner July 2, 2025 12:54
@zorro-bot

zorro-bot Bot commented Jul 2, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.14%. Comparing base (ff1fa28) to head (49232aa).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nents/float-button/float-button-group.component.ts 93.47% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9267      +/-   ##
==========================================
+ Coverage   92.06%   92.14%   +0.07%     
==========================================
  Files         561      561              
  Lines       19609    19608       -1     
  Branches     3102     3102              
==========================================
+ Hits        18054    18068      +14     
+ Misses       1215     1202      -13     
+ Partials      340      338       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread components/float-button/float-button-group.component.ts Outdated
@Nicoss54
Nicoss54 self-requested a review July 3, 2025 14:52

@Nicoss54 Nicoss54 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread components/float-button/float-button-group.component.ts Outdated
Comment thread components/float-button/float-button-group.component.ts Outdated
@WwwHhhYran
WwwHhhYran force-pushed the feat/support_nzPlacement_for_float_btn branch from ae07abc to 49232aa Compare July 15, 2025 06:37
@WwwHhhYran
WwwHhhYran requested a review from Laffery July 15, 2025 06:40

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery added this to the v20.1 milestone Jul 15, 2025
@Laffery
Laffery merged commit 9dc19f3 into NG-ZORRO:master Jul 17, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants