Skip to content

feat(module:input): input-otp supports keyboard control positioning - #9268

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
iaosee:feat/input-otp
Jul 17, 2025
Merged

Laffery merged 1 commit into
NG-ZORRO:masterfrom
iaosee:feat/input-otp

Conversation

@iaosee

@iaosee iaosee commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@iaosee
iaosee requested a review from vthinkxie as a code owner July 2, 2025 14:45
@zorro-bot

zorro-bot Bot commented Jul 2, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jul 2, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.08%. Comparing base (2c7c402) to head (c0eb614).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
components/input/input-otp.component.ts 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9268      +/-   ##
==========================================
- Coverage   92.11%   92.08%   -0.03%     
==========================================
  Files         561      561              
  Lines       19609    19616       +7     
  Branches     3101     3104       +3     
==========================================
+ Hits        18062    18064       +2     
- Misses       1207     1211       +4     
- Partials      340      341       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit da97b02 into NG-ZORRO:master Jul 17, 2025
@iaosee
iaosee deleted the feat/input-otp branch July 23, 2025 16:56
@iaosee
iaosee restored the feat/input-otp branch July 23, 2025 16:58
@iaosee
iaosee deleted the feat/input-otp branch July 23, 2025 16:59
@iaosee
iaosee restored the feat/input-otp branch August 19, 2025 01:55
@iaosee
iaosee deleted the feat/input-otp branch August 19, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants