Skip to content

feat(module:popconfirm): add nzDanger support to cancel button - #9270

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Nicoss54:feature/nz-danger-close-pop-confirm
Jul 17, 2025
Merged

feat(module:popconfirm): add nzDanger support to cancel button#9270
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Nicoss54:feature/nz-danger-close-pop-confirm

Conversation

@Nicoss54

@Nicoss54 Nicoss54 commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

the close button for the pop confirm component does not support nzDanger

What is the new behavior?

the close button for the pop confirm component now support nzDanger

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Nicoss54
Nicoss54 requested a review from simplejason as a code owner July 3, 2025 17:37
@Nicoss54
Nicoss54 requested review from HyperLife1119 and Laffery July 3, 2025 17:37
@Nicoss54 Nicoss54 self-assigned this Jul 3, 2025
@zorro-bot

zorro-bot Bot commented Jul 3, 2025

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.11%. Comparing base (2c7c402) to head (61adce8).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9270   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         561      561           
  Lines       19609    19609           
  Branches     3101     3101           
=======================================
  Hits        18062    18062           
  Misses       1207     1207           
  Partials      340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery added this to the v20.1 milestone Jul 10, 2025
@Laffery
Laffery merged commit f94cb31 into NG-ZORRO:master Jul 17, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants