Skip to content

feat(module:space): support array for size - #9289

Merged
WwwHhhYran merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:feat/space-size-array
Jul 17, 2025
Merged

feat(module:space): support array for size#9289
WwwHhhYran merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:feat/space-size-array

Conversation

@HyperLife1119

@HyperLife1119 HyperLife1119 commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

nzSize 不支持数组类型,而 nzWrap 示例需要使用数组类型的 nzSize

What is the new behavior?

  • nzSize 支持数组,并且将 style 实现从 margin 改为 gap(与 antd 的实现一致)
  • 添加 nzWrap 示例

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.11%. Comparing base (7c7de92) to head (aa3290e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9289   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         561      561           
  Lines       19609    19615    +6     
  Branches     3101     3103    +2     
=======================================
+ Hits        18062    18068    +6     
  Misses       1207     1207           
  Partials      340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread components/space/space.component.ts Outdated
Comment thread components/space/space.component.ts Outdated
@HyperLife1119
HyperLife1119 force-pushed the feat/space-size-array branch from cca693d to 91388f1 Compare July 16, 2025 08:41

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WwwHhhYran WwwHhhYran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WwwHhhYran
WwwHhhYran merged commit 8809885 into NG-ZORRO:master Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants