Skip to content

feat(module:schematics): align with the updated style guide - #9295

Merged
Laffery merged 4 commits into
NG-ZORRO:masterfrom
Laffery:schematics/style-update
Jul 21, 2025
Merged

feat(module:schematics): align with the updated style guide#9295
Laffery merged 4 commits into
NG-ZORRO:masterfrom
Laffery:schematics/style-update

Conversation

@Laffery

@Laffery Laffery commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

在 Angular v20 更新的风格指南中,新项目默认 app.ts 等文件不带有 component 扩展名,这导致基于 ng-zorro-antd 的 schematics 模板生成的代码与之不匹配。

What is the new behavior?

  • 对齐 Angular v20 更新的风格指南,支持指定 ng-componenttype ngHtml 等扩展名配置项,以及 skipSelector exportDefault 配置项
  • ng-add 新增可选模板 topnav

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Jul 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (add21f7) to head (5a1c30c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9295      +/-   ##
==========================================
- Coverage   92.12%   92.08%   -0.05%     
==========================================
  Files         561      561              
  Lines       19627    19627              
  Branches     3106     3106              
==========================================
- Hits        18082    18074       -8     
- Misses       1206     1214       +8     
  Partials      339      339              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery Laffery added this to the v20.1 milestone Jul 20, 2025
@Laffery Laffery changed the title Schematics/style update feat(module:schematics): align with the updated style guide Jul 20, 2025
@Laffery
Laffery requested a review from HyperLife1119 July 20, 2025 04:24
@Laffery

Laffery commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator Author

本地测试有点问题,处理中

@Laffery
Laffery force-pushed the schematics/style-update branch from cdba1ba to df1633c Compare July 20, 2025 05:59
@Laffery

Laffery commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator Author

本地测试有点问题,处理中

问题已修复,本地 CLI 运行测试通过

@Laffery
Laffery force-pushed the schematics/style-update branch from 208ee3a to d3a0eef Compare July 20, 2025 06:23
@Laffery
Laffery force-pushed the schematics/style-update branch from 0959ab1 to 5a1c30c Compare July 20, 2025 07:23

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit b5f607b into NG-ZORRO:master Jul 21, 2025
@Laffery
Laffery deleted the schematics/style-update branch June 27, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants