Skip to content

fix(module:table): add cdkScrollable to internal scrolling element - #9308

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:fix/table-cdk-scrollable
Aug 5, 2025
Merged

fix(module:table): add cdkScrollable to internal scrolling element#9308
Laffery merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:fix/table-cdk-scrollable

Conversation

@HyperLife1119

@HyperLife1119 HyperLife1119 commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #7371, #6986

在 nz-table 开启滚动后,会在内部创建一个 ant-table-body 作为滚动元素,然而用户无法为这个元素添加任何指令,这会影响一些需要用到 cdkScrollable 的常见用例。

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.12%. Comparing base (d3bc0ee) to head (8212e3f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9308   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files         561      561           
  Lines       19627    19627           
  Branches     3106     3106           
=======================================
  Hits        18082    18082           
  Misses       1206     1206           
  Partials      339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit 8cb4113 into NG-ZORRO:master Aug 5, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants