Skip to content

fix(module:popconfirm): correctly render icon and title - #9322

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:fix/popconfirm-icon
Aug 8, 2025
Merged

Laffery merged 1 commit into
NG-ZORRO:masterfrom
HyperLife1119:fix/popconfirm-icon

Conversation

@HyperLife1119

@HyperLife1119 HyperLife1119 commented Aug 8, 2025 •

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

  • 当 nzTitle 传入类型为 TemplateRef 时,icon 不会被渲染,这是错误的,title 不应该影响 icon 的渲染;如果不想渲染 icon,应当将 nzIcon 设置为 null。
  • 自定义 icon 时候,没有将 icon 渲染在 ant-popover-message-icon 下(缺少右边距)。
image

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Aug 8, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.12%. Comparing base (77e0b62) to head (14d87c1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9322   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files         561      561           
  Lines       19631    19631           
  Branches     3107     3107           
=======================================
  Hits        18086    18086           
  Misses       1206     1206           
  Partials      339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HyperLife1119 HyperLife1119 changed the title fix(module:popconfirm): correctly render custom icon fix(module:popconfirm): correctly render icon and title Aug 8, 2025

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit 2c83788 into NG-ZORRO:master Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants