Repository navigation
feat(module:select,tree-select,cascader): support prefix and suffix icon - #9328
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9328 +/- ##
==========================================
- Coverage 92.12% 92.12% -0.01%
==========================================
Files 561 561
Lines 19631 19632 +1
Branches 3107 2997 -110
==========================================
Hits 18086 18086
- Misses 1206 1207 +1
Partials 339 339 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Laffery i’m on it :) |
Nicoss54
left a comment
There was a problem hiding this comment.
Some question, but not big change to do. I thinks it's just a nice to have
| return this.expandedKeys; | ||
| } | ||
|
|
||
| @Input() nzPrefix: TemplateRef<NzSafeAny> | string | null = null; |
There was a problem hiding this comment.
question: cause it's a new feature why not using input based signal ?
There was a problem hiding this comment.
There is something wrong with input() in SSR I cannot figure out.
The code is:
@if (nzPrefix(); as prefix) {
<div class="ant-select-prefix">
<ng-container *nzStringTemplateOutlet="prefix">{{ prefix }}</ng-container>
</div>
}[input signal: undefined] appears in the first render
So I just keep using @Input here
I've updated as your suggestions :) |
* test(module:tree-select): add missing inputs * test(module:tooltip): fix arrow bgColor case involved in #9360 * test(module:select): fix select-arrow visibility error involved in #9328 * test(module:cascader): fix missing signal value invocation * test(module:cascader): fix missing NzInputGroupDirective query * test(module:cascader): fix pipe not provided * test(module:mention): missing Directionality.valueSignal * test(module:autocomplete): deprecated input group * chore: update test script * ci: fix pipelines config * ci: correct junit output dir * test(module:affix): revert fromEventOutsideAngular * test(module:dropdown): re-organize test cases --------- Co-authored-by: HyperLife1119 <hyperlife1119@qq.com>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: close #6344 #9327
What is the new behavior?
nz-select
nz-select-top-controlcomponent to align with Ant Design. As a result there are lots of styles being changednzPrefixnz-tree-select
nzPrefixandnzSuffixIconnz-cascader
nzPrefixDoes this PR introduce a breaking change?
Other information