Skip to content

feat(module:dropdown): display arrow for content dropdown - #9329

Merged
Laffery merged 3 commits into
NG-ZORRO:masterfrom
Nicoss54:feature/dropdown-nz-arrow
Aug 22, 2025
Merged

Laffery merged 3 commits into
NG-ZORRO:masterfrom
Nicoss54:feature/dropdown-nz-arrow

Conversation

@Nicoss54

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Drowpdown component miss the displaying of an arrow on the contend dropdown menu

Issue Number: N/A

What is the new behavior?

Dropdown component displayed an arrow on the content dropdown menu as the andt-design do:

https://ant.design/components/dropdown#dropdown-demo-arrow-center

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Aug 16, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.13%. Comparing base (b0a4287) to head (56d63af).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #9329    +/-   ##
========================================
  Coverage   92.12%   92.13%            
========================================
  Files         561      561            
  Lines       19631    19650    +19     
  Branches     3107     3005   -102     
========================================
+ Hits        18086    18105    +19     
  Misses       1206     1206            
  Partials      339      339            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery Laffery changed the title feat(module:dropdown): display array for content dropdown feat(module:dropdown): display arrow for content dropdown Aug 16, 2025

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd left a small suggestion on the showcase code

Comment thread components/dropdown/demo/arrow.ts Outdated
@Nicoss54

Copy link
Copy Markdown
Collaborator Author

@Laffery @HyperLife1119 could you paid attention to the trad, cause i used google trad and i'm not sure about the traduction. Really sorry for that

Comment thread components/dropdown/demo/arrow.md Outdated
@Laffery

Laffery commented Aug 16, 2025

Copy link
Copy Markdown
Collaborator

@Laffery @HyperLife1119 could you paid attention to the trad, cause i used google trad and i'm not sure about the traduction. Really sorry for that

they are nice

Comment thread components/dropdown/demo/arrow.md Outdated
Comment thread components/dropdown/dropdown.directive.ts Outdated
@Laffery Laffery added this to the v20.2 milestone Aug 18, 2025

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nicoss54 and others added 2 commits August 18, 2025 09:37
@Laffery
Laffery merged commit 3686b73 into NG-ZORRO:master Aug 22, 2025
@Nicoss54
Nicoss54 deleted the feature/dropdown-nz-arrow branch September 11, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MILESTONE 2025 🔥🔥 dropdown: add nzArrow property to show an arrow

3 participants