Skip to content

fix(module:select): shaking when closing dropdown if use a TemplateRef as notFoundContent (#8931) - #9336

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
keke521jie:fix/select-closing-shaking
Aug 21, 2025
Merged

Laffery merged 1 commit into
NG-ZORRO:masterfrom
keke521jie:fix/select-closing-shaking

Conversation

@keke521jie

@keke521jie keke521jie commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #8931

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Comment thread components/empty/embed-empty.component.ts
@keke521jie
keke521jie force-pushed the fix/select-closing-shaking branch from ee4a56b to 59af5a6 Compare August 20, 2025 07:18
@codecov

codecov Bot commented Aug 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.13%. Comparing base (b0a4287) to head (f3b7740).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #9336    +/-   ##
========================================
  Coverage   92.12%   92.13%            
========================================
  Files         561      561            
  Lines       19631    19630     -1     
  Branches     3107     3000   -107     
========================================
+ Hits        18086    18087     +1     
  Misses       1206     1206            
+ Partials      339      337     -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread components/empty/embed-empty.component.ts Outdated
Comment thread components/empty/embed-empty.component.ts
@keke521jie
keke521jie force-pushed the fix/select-closing-shaking branch from 59af5a6 to f3b7740 Compare August 21, 2025 01:46
@Laffery Laffery changed the title fix(module:select): fix select close shaking (#8931) fix(module:select): shaking when closing dropdown if use a TemplateRef as notFoundContent (#8931) Aug 21, 2025

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit 366f8eb into NG-ZORRO:master Aug 21, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nz-select:When passing in 'nzNotFoundContent' to 'TemplateRef', closing the dropdown menu will cause shaking

2 participants