Skip to content

feat(module:divider): support nzSize - #9346

Merged
Laffery merged 2 commits into
NG-ZORRO:masterfrom
Nicoss54:feature/divider-size
Aug 25, 2025
Merged

Laffery merged 2 commits into
NG-ZORRO:masterfrom
Nicoss54:feature/divider-size

Conversation

@Nicoss54

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Divider component support nzSize

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Aug 22, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.09%. Comparing base (ce611e5) to head (ad7187c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9346      +/-   ##
==========================================
- Coverage   92.13%   92.09%   -0.04%     
==========================================
  Files         561      561              
  Lines       19649    19652       +3     
  Branches     3003     3004       +1     
==========================================
- Hits        18104    18099       -5     
- Misses       1208     1216       +8     
  Partials      337      337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nicoss54
Nicoss54 force-pushed the feature/divider-size branch from 1dca4a8 to 0ead356 Compare August 22, 2025 14:20
Comment thread components/divider/divider.component.ts Outdated
@Nicoss54
Nicoss54 requested a review from Laffery August 23, 2025 15:26

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit 1f54536 into NG-ZORRO:master Aug 25, 2025
@Nicoss54
Nicoss54 deleted the feature/divider-size branch August 29, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants