Repository navigation
feat(module:collapse): add support of nzSize - #9348
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9348 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 561 561
Lines 19649 19653 +4
Branches 3003 3004 +1
=======================================
+ Hits 18104 18108 +4
Misses 1208 1208
Partials 337 337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Laffery @HyperLife1119 if one of both of you could just rereun the linter it could be nice :) Currently it failed cause the npm install step crash ... |
triggered |
@Laffery oh thanks you rock :) |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the nzSize property to the Collapse component, allowing users to set the size of collapse panels to 'small', 'middle' (default), or 'large'.
- Adds
nzSizeinput property with typeNzSizeLMSTypeand default value 'middle' - Implements CSS styling for small and large size variants with appropriate padding adjustments
- Updates documentation in both English and Chinese to document the new property
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| components/collapse/collapse.component.ts | Adds nzSize input property and host class bindings for size variants |
| components/collapse/style/index.less | Implements CSS styles for small and large collapse sizes with adjusted padding |
| components/collapse/doc/index.zh-CN.md | Documents nzSize property in Chinese documentation |
| components/collapse/doc/index.en-US.md | Documents nzSize property in English documentation |
| components/collapse/demo/size.ts | Creates demo component showcasing different collapse sizes |
| components/collapse/demo/size.md | Adds demo documentation for size feature |
| components/collapse/collapse.spec.ts | Adds comprehensive tests for size functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Laffery again if you could just re run the lint and test on the pipeline could be very nice Failed again at the step on npm istall, seems to be a problem with the connection to the npm regsitry |
|
LGTM |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Collapse component now support nzSize property
Does this PR introduce a breaking change?
Other information