Skip to content

fix(module:carousel): wrong dot postion when left and right - #9358

Merged
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Nicoss54:fix/nzdotPosition
Aug 28, 2025
Merged

fix(module:carousel): wrong dot postion when left and right#9358
Laffery merged 1 commit into
NG-ZORRO:masterfrom
Nicoss54:fix/nzdotPosition

Conversation

@Nicoss54

@Nicoss54 Nicoss54 commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

When nzDotPosition is set to right or left the position is of dots is not correct

Issue Number: N/A

What is the new behavior?

Dot position is fixed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Aug 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (025f9f9) to head (25acedf).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9358      +/-   ##
==========================================
+ Coverage   92.09%   92.27%   +0.17%     
==========================================
  Files         561      561              
  Lines       19657    19654       -3     
  Branches     3005     3006       +1     
==========================================
+ Hits        18104    18135      +31     
+ Misses       1216     1188      -28     
+ Partials      337      331       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laffery Laffery changed the title fix(module:carousel): dot postion when left and rigth fix(module:carousel): wrong dot postion when left and right Aug 28, 2025

@WwwHhhYran WwwHhhYran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread components/carousel/style/index.less Outdated

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Laffery merged commit f117ccb into NG-ZORRO:master Aug 28, 2025
9 of 10 checks passed
@Nicoss54
Nicoss54 deleted the fix/nzdotPosition branch August 29, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nz-carousel: nzDotPosition css not working

3 participants