fix(module:carousel): wrong dot postion when left and right - #9358
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9358 +/- ##
==========================================
+ Coverage 92.09% 92.27% +0.17%
==========================================
Files 561 561
Lines 19657 19654 -3
Branches 3005 3006 +1
==========================================
+ Hits 18104 18135 +31
+ Misses 1216 1188 -28
+ Partials 337 331 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WwwHhhYran
approved these changes
Aug 28, 2025
Nicoss54
force-pushed
the
fix/nzdotPosition
branch
from
August 28, 2025 08:48
6fb12ce to
25acedf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When nzDotPosition is set to right or left the position is of dots is not correct
Issue Number: N/A
What is the new behavior?
Dot position is fixed
Does this PR introduce a breaking change?
Other information