Skip to content

feat(module:segmented): support nzName and keyboard interactions - #9373

Merged
HyperLife1119 merged 1 commit into
NG-ZORRO:masterfrom
Laffery:feat/segmented-with-name
Sep 1, 2025
Merged

feat(module:segmented): support nzName and keyboard interactions#9373
HyperLife1119 merged 1 commit into
NG-ZORRO:masterfrom
Laffery:feat/segmented-with-name

Conversation

@Laffery

@Laffery Laffery commented Aug 31, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • support keyboard interactions to control the selected item
  • add nzName property to set native name attribute of input[type="radio"]

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Aug 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.27%. Comparing base (9d42b42) to head (6fa5d6b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
components/segmented/segmented.component.ts 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9373      +/-   ##
==========================================
+ Coverage   92.25%   92.27%   +0.01%     
==========================================
  Files         561      561              
  Lines       19684    19721      +37     
  Branches     3015     3025      +10     
==========================================
+ Hits        18160    18198      +38     
+ Misses       1192     1191       -1     
  Partials      332      332              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nicoss54 Nicoss54 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery changed the title feat(module:segmented): wip support nzName and keyboard interactions feat(module:segmented): support nzName and keyboard interactions Aug 31, 2025

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119
HyperLife1119 merged commit ebd8bdc into NG-ZORRO:master Sep 1, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants