Repository navigation
fix(module:result): nz-result-icon in ng-content does not work - #9511
Merged
Merged
Conversation
Laffery
commented
Nov 9, 2025
| : icon | ||
| : this.isException | ||
| ? undefined | ||
| : IconMap[this.nzStatus as NzResultIconType]; |
Collaborator
Author
There was a problem hiding this comment.
When nzIcon is undefined, the icon will be IconMap[this.nzStatus as NzResultIconType], which makes the icon always be truthy and the nz-result-icon is defined in the ng-content will not work forever
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9511 +/- ##
==========================================
- Coverage 90.11% 90.06% -0.05%
==========================================
Files 570 570
Lines 23382 23379 -3
Branches 4644 4650 +6
==========================================
- Hits 21070 21057 -13
- Misses 1606 1614 +8
- Partials 706 708 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information