Skip to content

fix(module:segmented): should not block the selected stream if no animation - #9512

Merged
HyperLife1119 merged 1 commit into
NG-ZORRO:masterfrom
Laffery:fix/segmented-animation
Nov 11, 2025
Merged

HyperLife1119 merged 1 commit into
NG-ZORRO:masterfrom
Laffery:fix/segmented-animation

Conversation

@Laffery

@Laffery Laffery commented Nov 9, 2025

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov

codecov Bot commented Nov 9, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.10%. Comparing base (18b5f18) to head (d7317f3).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
components/segmented/segmented-item.component.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9512      +/-   ##
==========================================
- Coverage   90.11%   90.10%   -0.01%     
==========================================
  Files         570      570              
  Lines       23382    23385       +3     
  Branches     4644     4645       +1     
==========================================
+ Hits        21070    21071       +1     
- Misses       1606     1608       +2     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HyperLife1119

Copy link
Copy Markdown
Collaborator

Could you add some tests :)

@Laffery

Laffery commented Nov 11, 2025

Copy link
Copy Markdown
Collaborator Author

Could you add some tests :)

In fact, it is precisely this issue that caused the following test cases to fail.

image image

I have made some changes to fix several test issues. I submitted this issue separately in this PR because I had to modify the component logic.

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119
HyperLife1119 merged commit af8b531 into NG-ZORRO:master Nov 11, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants