Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary: band-aid for missing stacktrace #12

Merged
merged 1 commit into from
Apr 10, 2023
Merged

summary: band-aid for missing stacktrace #12

merged 1 commit into from
Apr 10, 2023

Conversation

msagarpatel
Copy link
Collaborator

@msagarpatel msagarpatel commented Apr 8, 2023

The following error was reported by @vustef:

│    BoundsError: attempt to access 0-element Vector{Any} at index [1]
│    Stacktrace:
│      [1] getindex
│        @ ./array.jl:924 [inlined]
│      [2] _summarize_exception(io::IOBuffer, exc::InterruptException, stack::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}}; prefix::Nothing)
│        @ ExceptionUnwrapping ~/.julia/packages/ExceptionUnwrapping/Yl4ht/src/exception_summary.jl:141

It's unclear why the stacktrace is missing, but this PR should prevent another exception from being thrown.


I recommend not showing whitespace while reviewing.

The following error was reported by @vustef:

	│    BoundsError: attempt to access 0-element Vector{Any} at index [1]
	│    Stacktrace:
	│      [1] getindex
	│        @ ./array.jl:924 [inlined]
	│      [2] _summarize_exception(io::IOBuffer, exc::InterruptException, stack::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}}; prefix::Nothing)
	│        @ ExceptionUnwrapping ~/.julia/packages/ExceptionUnwrapping/Yl4ht/src/exception_summary.jl:141

It's unclear why the stacktrace is missing, but this PR should prevent
another exception from being thrown.
@msagarpatel msagarpatel requested a review from NHDaly April 8, 2023 00:15
@NHDaly NHDaly merged commit f2a5b11 into master Apr 10, 2023
@NHDaly NHDaly deleted the sp-no-backtrace branch April 10, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants