Skip to content

CCM-8270: Aggregate error items#897

Merged
simonlabarere merged 1 commit into
releasefrom
feature/CCM-8270
Apr 4, 2025
Merged

CCM-8270: Aggregate error items#897
simonlabarere merged 1 commit into
releasefrom
feature/CCM-8270

Conversation

@simonlabarere
Copy link
Copy Markdown
Contributor

@simonlabarere simonlabarere commented Mar 19, 2025

Summary

This is a minor change to accommodate this BE PR: https://github.com/NHSDigital/comms-mgr/pull/515 in order to:

  • Use the status code returned by the BE for each error item
  • Not populate the source on an error item when it's not provided by the BE
  • Allow the BE to return 404 errors and translate them instead of just returning a generic error

Note that the internal-dev tests can only pass with the new BE.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

4 similar comments
@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

@simonlabarere simonlabarere changed the title NO_JIRA: point at de-sila7 CCM-8270: Aggregate error items Mar 21, 2025
@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-8270

@simonlabarere simonlabarere merged commit c98902e into release Apr 4, 2025
@simonlabarere simonlabarere deleted the feature/CCM-8270 branch April 4, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants