Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Got to update checksum of truncated packets #108
When Jool truncates ICMP error messages, it forgets to update the ICMP checksum.
In practice, this shouldn't be a problem because the original packet would have to have been translated by Jool with no problems, and generating an error message bigger than the packet that caused it makes no sense. Therefore, Jool should never have to slice ICMP errors in the first place.
Still, it better be prepared against weird implementations out there.