New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got to update checksum of truncated packets #108

Closed
ydahhrk opened this Issue Sep 8, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@ydahhrk
Member

ydahhrk commented Sep 8, 2014

When Jool truncates ICMP error messages, it forgets to update the ICMP checksum.

In practice, this shouldn't be a problem because the original packet would have to have been translated by Jool with no problems, and generating an error message bigger than the packet that caused it makes no sense. Therefore, Jool should never have to slice ICMP errors in the first place.

Still, it better be prepared against weird implementations out there.

@ydahhrk ydahhrk self-assigned this Sep 8, 2014

@ydahhrk ydahhrk added this to the 3.2.1 milestone Sep 8, 2014

ydahhrk added a commit that referenced this issue Sep 12, 2014

Issue #108. Jool was actually forgetting to update Payload Length; Ch…
…ecksum was correct.

Still, I also refactored a lot of checksumming code, to stop sparse's whining.

ydahhrk added a commit that referenced this issue Oct 8, 2014

Merging version 3.2.1 into master, hereby makingthe changes official.
Version 3.2.1 is 3.2.0 with issues #57, #106, #108 and #109 fixed.
Issue #107 has been marked as duplicate and postponed to 3.3.0.

rting with '#' will be ignored, and an empty message aborts

@ydahhrk ydahhrk closed this Oct 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment