Certain sk_buffs are not being released from memory #109

Closed
ydahhrk opened this Issue Sep 8, 2014 · 0 comments

Projects

None yet

1 participant

@ydahhrk
Member
ydahhrk commented Sep 8, 2014

We have a memory leak in the core module.

When there is fragmentation involved, sk_buffs are queued. When translation is successful, Jool asks the kernel to drop the packet. Because the kernel doesn't know the sk_buffs are queued, it only frees the first one.

This is that one bug that only applies to 3.2.0. It does not apply to the 3.1 series.

@ydahhrk ydahhrk self-assigned this Sep 8, 2014
@ydahhrk ydahhrk added this to the 3.2.1 milestone Sep 8, 2014
@ydahhrk ydahhrk added a commit that referenced this issue Sep 15, 2014
@ydahhrk ydahhrk Issue #109.
By testing the checksums again, I realized that there's no reason to not update inner packet checksums anymore, and wireshark would judge Jool's packets better if we do.
Therefore, I'm going to refactor Translate a bit again. Checkpoint.
66a09f0
@ydahhrk ydahhrk added a commit that referenced this issue Oct 8, 2014
@ydahhrk ydahhrk Merging version 3.2.1 into master, hereby makingthe changes official.
Version 3.2.1 is 3.2.0 with issues #57, #106, #108 and #109 fixed.
Issue #107 has been marked as duplicate and postponed to 3.3.0.

rting with '#' will be ignored, and an empty message aborts
3025ec2
@ydahhrk ydahhrk closed this Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment