Make user-space utility exit unsuccessfully when encountering errors #184

Closed
toreanderson opened this Issue Nov 11, 2015 · 1 comment

Projects

None yet

2 participants

@toreanderson
Contributor

I botched the upgrade to v3.4.0 on one of my BRs, getting the kernel module and the user-space utility out of sync. Therefore Jool ended up in an unconfigured state. The unfortunate thing is that the start-up scripts incorrectly believed that Jool was initialised just fine, and therefore proceeded to start up BIRD to advertise routes to the various IP pools to the rest of the network. This caused blackholing of traffic.

The problem would not have occurred if the user-space app had exited unsuccessfully when encountering any error.

$ /usr/bin/jool_siit -e 
Error: (Error code: 22)
  (empty)
$ echo $?
0
$ dmesg | tail -n 1
[  461.694810] SIIT Jool ERROR (validate_version): Version mismatch. The kernel module is 3.3.4.0, but the userspace application is 3.3.2.12. Please update Jool's userspace application.
@ydahhrk ydahhrk closed this in 95a8f10 Nov 11, 2015
@ydahhrk
Member
ydahhrk commented Nov 11, 2015

Sorry :/

@ydahhrk ydahhrk added this to the 3.4.1 milestone Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment