New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unprivileged users from running `--display` on sensitive databases. #191

Closed
ydahhrk opened this Issue Nov 18, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@ydahhrk
Member

ydahhrk commented Nov 18, 2015

Operations that do not alter databases (--display and --count) are free to use by anyone, currently.

The output of jool --bib --display and jool --session --display can be delicate. End users might not appreciate their mappings being visible to anyone with login access to the Jool machine. iptables demands privileges to display its mappings database, and we should probably do the same.

I'm planning to hide --bib --display and --session --display behind an if (capable(CAP_NET_ADMIN)). I'm not sure if other configuration modes (such as --global and --pool4) should get similar treatment.

@ydahhrk ydahhrk closed this in 1a0dfab Nov 19, 2015

@ydahhrk ydahhrk added this to the 3.4.2 milestone Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment