New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module build fails with kernel 4.6.4 #219

Closed
toreanderson opened this Issue Aug 8, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@toreanderson
Contributor

toreanderson commented Aug 8, 2016

When attemping to build Jool Git master or release v3.4.3 on a fully uptodate Fedora 24 x86_64 system (kernel version 4.6.4-301.fc24.x86_64) it fails like so:

tore@echo:~/git/Jool/mod$ make
make -C stateless
make[1]: Entering directory '/git/Jool/mod/stateless'
make -C /lib/modules/4.6.4-301.fc24.x86_64/build M=$PWD JOOL_FLAGS=""
make[2]: Entering directory '/usr/src/kernels/4.6.4-301.fc24.x86_64'
  LD      /git/Jool/mod/stateless/built-in.o
  CC [M]  /git/Jool/mod/stateless/../common/rfc6145/4to6.o
  CC [M]  /git/Jool/mod/stateless/../common/rfc6145/6to4.o
  CC [M]  /git/Jool/mod/stateless/../common/rfc6145/common.o
  CC [M]  /git/Jool/mod/stateless/../common/rfc6145/core.o
  CC [M]  /git/Jool/mod/stateless/../common/address.o
  CC [M]  /git/Jool/mod/stateless/../common/types.o
  CC [M]  /git/Jool/mod/stateless/../common/str_utils.o
  CC [M]  /git/Jool/mod/stateless/../common/packet.o
  CC [M]  /git/Jool/mod/stateless/../common/stats.o
  CC [M]  /git/Jool/mod/stateless/../common/log_time.o
  CC [M]  /git/Jool/mod/stateless/../common/icmp_wrapper.o
  CC [M]  /git/Jool/mod/stateless/../common/ipv6_hdr_iterator.o
  CC [M]  /git/Jool/mod/stateless/../common/pool6.o
  CC [M]  /git/Jool/mod/stateless/../common/rfc6052.o
  CC [M]  /git/Jool/mod/stateless/../common/rtrie.o
  CC [M]  /git/Jool/mod/stateless/../common/nl_buffer.o
  CC [M]  /git/Jool/mod/stateless/../common/rbtree.o
  CC [M]  /git/Jool/mod/stateless/../common/config.o
  CC [M]  /git/Jool/mod/stateless/../common/nl_handler.o
  CC [M]  /git/Jool/mod/stateless/../common/route.o
/git/Jool/mod/stateless/../common/route.c: In function ‘route6’:
/git/Jool/mod/stateless/../common/route.c:131:6: error: ‘struct flowi6’ has no member named ‘flowi6_tos’
  flow.flowi6_tos = get_traffic_class(hdr_ip);
      ^
scripts/Makefile.build:291: recipe for target '/git/Jool/mod/stateless/../common/route.o' failed
make[3]: *** [/git/Jool/mod/stateless/../common/route.o] Error 1
Makefile:1433: recipe for target '_module_/git/Jool/mod/stateless' failed
make[2]: *** [_module_/git/Jool/mod/stateless] Error 2
make[2]: Leaving directory '/usr/src/kernels/4.6.4-301.fc24.x86_64'
Makefile:5: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/git/Jool/mod/stateless'
Makefile:8: recipe for target 'stateless' failed
make: *** [stateless] Error 2

ydahhrk added a commit that referenced this issue Aug 9, 2016

@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Aug 9, 2016

Member

Sorry, man. I don't think this is the first time you've reported something like this and that shows I'm lagging behind. I found this "Latest Linux Kernel" RSS feed and hopefully this should never happen again. We'll see.

That said, I didn't have time to download the latest Fedora and, though a unit test managed to catch a horrendous bug I was about to throw at you, this is untested in the actual target environment. I'll see if I can upgrade one of my VMs at some point in the week but my schedule is somewhat tight.

If there's something wrong, however, it should crash very early. If it doesn't it's probably fine. But this is just a developer's take on it.

Member

ydahhrk commented Aug 9, 2016

Sorry, man. I don't think this is the first time you've reported something like this and that shows I'm lagging behind. I found this "Latest Linux Kernel" RSS feed and hopefully this should never happen again. We'll see.

That said, I didn't have time to download the latest Fedora and, though a unit test managed to catch a horrendous bug I was about to throw at you, this is untested in the actual target environment. I'll see if I can upgrade one of my VMs at some point in the week but my schedule is somewhat tight.

If there's something wrong, however, it should crash very early. If it doesn't it's probably fine. But this is just a developer's take on it.

@toreanderson

This comment has been minimized.

Show comment
Hide comment
@toreanderson

toreanderson Aug 9, 2016

Contributor

No worries, I know you'll have to play catch-up with upstream kernel API changes. Just thought I'd let you know, that's all - there's no rush. Anyway, I fetched the issue219 branch and it builds fine. Thanks! I'll test functionality later today.

Contributor

toreanderson commented Aug 9, 2016

No worries, I know you'll have to play catch-up with upstream kernel API changes. Just thought I'd let you know, that's all - there's no rush. Anyway, I fetched the issue219 branch and it builds fine. Thanks! I'll test functionality later today.

@ydahhrk ydahhrk added this to the 3.4.5 milestone Sep 14, 2016

@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Sep 19, 2016

Member

Tested, released, closing.

Member

ydahhrk commented Sep 19, 2016

Tested, released, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment