Log messages might be unnecesary. #57

Closed
ydahhrk opened this Issue May 27, 2013 · 2 comments

Projects

None yet

2 participants

@ydahhrk
Member
ydahhrk commented May 27, 2013

Whenever the module drops a packet, it logs an error message.
Apparently, the kernel uses a statistics mechanism instead (see the STATS functions in http://lxr.free-electrons.com/source/include/net/ip.h).
We should see if we ought to do the same.

@ydahhrk ydahhrk was assigned May 27, 2013
@ydahhrk ydahhrk added this to the 3.1.5 milestone Mar 26, 2014
@ydahhrk ydahhrk self-assigned this Apr 16, 2014
@ydahhrk ydahhrk added a commit that referenced this issue May 15, 2014
@ydahhrk ydahhrk First step of issue #57.
Downgraded most logging messages to debug priority because we're
no longer going to bother users with them unless debug is turned
on.
Added stats functions to the packet module.
The code still doesn't compile; I'm only committing because I need
to pay attention to some other stuff for a while.
a675aa2
@ydahhrk ydahhrk added a commit that referenced this issue Jun 13, 2014
@ydahhrk ydahhrk Lots of bugfixes to the merge.
Issue #57 is probably 80% done.
f17058d
@ydahhrk
Member
ydahhrk commented Jun 24, 2014

Stats functions included, and many error messages have less priority now.

Fixed and collapsed to the master branch; closing.

@ydahhrk ydahhrk closed this Jun 24, 2014
@ydahhrk
Member
ydahhrk commented Sep 8, 2014

Reopening, because while the stats module exists, its callers are nowhere to be found. Looks like we had a faulty merge somewhere.

Raising priority, because there is currently no way to know why are packets being discarded unless one compiles with debug activated.

@ydahhrk ydahhrk reopened this Sep 8, 2014
@ydahhrk ydahhrk assigned dhfelix and unassigned ydahhrk Sep 8, 2014
@ydahhrk ydahhrk modified the milestone: 3.2.1, 3.1.5 Sep 12, 2014
@ydahhrk ydahhrk added a commit that referenced this issue Oct 8, 2014
@ydahhrk ydahhrk Merging version 3.2.1 into master, hereby makingthe changes official.
Version 3.2.1 is 3.2.0 with issues #57, #106, #108 and #109 fixed.
Issue #107 has been marked as duplicate and postponed to 3.3.0.

rting with '#' will be ignored, and an empty message aborts
3025ec2
@ydahhrk ydahhrk closed this Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment