New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions are not gone when the Address on the Pool change #65

Closed
basuam opened this Issue Aug 19, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@basuam

basuam commented Aug 19, 2013

When an address is added to the IPv4 Pool and some sessions are related to that address, and later that address is removed; the sessions related to the IPv4 address on the pool are still there.

@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Sep 27, 2013

Member

This is by design.
But looking back, I admit the design is dumb.
Looks fairly easy to fix, so we'll probably address it after fragmentation.

Member

ydahhrk commented Sep 27, 2013

This is by design.
But looking back, I admit the design is dumb.
Looks fairly easy to fix, so we'll probably address it after fragmentation.

@ydahhrk ydahhrk modified the milestones: 3.1.3, 3.1.1 Feb 20, 2014

@ydahhrk ydahhrk modified the milestones: 3.1.5, 3.1.4 Mar 26, 2014

@ydahhrk ydahhrk assigned dhfelix and ydahhrk and unassigned dhfelix Mar 27, 2014

@ydahhrk ydahhrk assigned dhfelix and unassigned ydahhrk Apr 16, 2014

dhfelix added a commit that referenced this issue May 6, 2014

ydahhrk added a commit that referenced this issue May 16, 2014

Lotsa revision, not done yet.
- Updated many comments.
- Noticed several errors, added more TODOs (identifiable by the
"issue #65" label).
- Deleted some functions no longer being used.
Also some pointless whims:
- Changed the name of the BIB lock because it was too wordy.
@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Jun 2, 2014

Member

Actual wishlist:

  • When a BIB entry is destroyed, its sessions die along with it.
  • When a IPv4 address is destroyed (from the IPv4 pool), its BIB entries must be destroyed as well (along with their sessions).
  • Whenever the user changes a session timeout, all of the relevant existing sessions must be updated.
Member

ydahhrk commented Jun 2, 2014

Actual wishlist:

  • When a BIB entry is destroyed, its sessions die along with it.
  • When a IPv4 address is destroyed (from the IPv4 pool), its BIB entries must be destroyed as well (along with their sessions).
  • Whenever the user changes a session timeout, all of the relevant existing sessions must be updated.
@ydahhrk

This comment has been minimized.

Show comment
Hide comment
@ydahhrk

ydahhrk Jun 24, 2014

Member

Fixed and collapsed to the master branch; closing.

Member

ydahhrk commented Jun 24, 2014

Fixed and collapsed to the master branch; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment